if (!params[:mission_statement_1].blank?) then
@user.missions.build :category => Category.find(params[:categories_1]), :statement => params[:mission_statement_1]
end
if (!params[:mission_statement_2].blank?) then
@user.missions.build :category => Category.find(params[:categories_2]), :statement => params[:mission_statement_2]
end
if (!params[:mission_statement_3].blank?) then
@user.missions.build :category => Category.find(params[:categories_3]), :statement => params[:mission_statement_3]
end
Should
if (!params[:mission_statement_1].blank?) then @user.missions.build :category => Category.find(params[:categories_1]), :statement => params[:mission_statement_1]
end
if (!params[:mission_statement_2].blank?) then @user.missions.build :category => Category.find(params[:categories_2]), :statement => params[:mission_statement_2]
end if (!params[:mission_statement_3].blank?) then @user.missions.build :category => Category.find(params[:categories_3]), :statement => params[:mission_statement_3]
end
be refactored to
(1..3).each{|x| @user.missions.build :category => Category.find(params['categories_' + x.to_s]), :statement => params['missionstatement' + x.to_s] unless params['missionstatement' + x.to_s].blank? }
or is it better to keep it as is for readability?