gnocode / noladex.org

People of New Orleans
http://www.noladex.org
21 stars 10 forks source link

Users#create question #34

Closed daybreaker closed 12 years ago

daybreaker commented 12 years ago

Should

if (!params[:mission_statement_1].blank?) then @user.missions.build :category => Category.find(params[:categories_1]), :statement => params[:mission_statement_1]
end
if (!params[:mission_statement_2].blank?) then @user.missions.build :category => Category.find(params[:categories_2]), :statement => params[:mission_statement_2]
end if (!params[:mission_statement_3].blank?) then @user.missions.build :category => Category.find(params[:categories_3]), :statement => params[:mission_statement_3]
end

be refactored to

(1..3).each{|x| @user.missions.build :category => Category.find(params['categories_' + x.to_s]), :statement => params['missionstatement' + x.to_s] unless params['missionstatement' + x.to_s].blank? }

or is it better to keep it as is for readability?