search

gnocode / noladex.org

People of New Orleans
http://www.noladex.org
21 stars 10 forks source link

Zoom / Crop images to fit. #4

Closed jbarnette closed 12 years ago

daybreaker commented 13 years ago

submitted a pull request to fix the cropping/scaling issue.

It wont scale up an image from less than 300px, because 1) the validation requires width and height >= 300px anyways, and 2) I dont think we should change that requirement, because scaling up always looks silly.

Besides, everyone should have an image of themselves with w/h >= 300px. It's 2011. Come on.

mshwery commented 12 years ago

Wasn't Ed working on something like this? I'm wondering if it's ready to merge?

daybreaker commented 12 years ago

I already submitted a fix, and I think Joe merged it.

It still requires minimum sizes of at least 300px for width and height, but if, for example, someone submits a 400 x 600 image, it will be resized to 300 x 450, and then the image will be centered with margins of 75px on each side being cropped out through overflow:hidden.

I figured that was easier than forcing them to use some built-in photo editor to re-size or crop.

EdwardReed commented 12 years ago

yea I was having trouble trying to get it to work along side of jquery but it's ok.

On Aug 19, 2011, at 8:21 AM, mshweryreply@reply.github.com wrote:

Wasn't Ed working on something like this? I'm wondering if it's ready to merge?

Reply to this email directly or view it on GitHub: https://github.com/gnocode/noladex.org/issues/4#issuecomment-1850883