joeellis
commented
12 years ago No there is no particular reason. The functionality you're speaking of was originally in Matt Ling's commit if I remember correctly, but I think I ended up changing it slightly because I thought that a person logged in may still want to add another person (a friend, etc). It's not for any particular reason though, it was just an arbitrary choice I made, and I just made the test to make things consistent so we can keep track of it (which surprisingly worked well as you've discovered it).
So you can feel free to change it if you think that way makes more sense, it wouldn't interrupt any larger plans that I know of.
Joe Ellis squarefour | www.squarefour.net 504.267.9321 joe@squarefour.net
On Tuesday, August 2, 2011 at 7:46 PM, vaxinate wrote:
So this seems potentially confusing for users who may not necessarily be extremely tech savvy. Also, the fact that a logged in user can still create an account seems like a weird thing to do. Not sure if this was done on purpose, but it really seems like it's just going to confuse people when they sign up, and still see a button asking them to sign up. Then when they sign up again, they get an error saying that their email is already in use.
I also noticed that in the User controller tests that we're testing that a log in user can sign up and create profiles. given that the user will have to log out to manage any additional accounts anyway, this seems like an unnecessary/unwanted feature. I wanted to post here and make sure that wasn't a design decision that I just don't understand before I spend time "fixing" it.
My idea was to have Users#new redirect to Users#edit for logged in users. Let me know if I'm missing something and we want it to stay the way it is.
Reply to this email directly or view it on GitHub: https://github.com/gnocode/noladex.org/issues/45
So this seems potentially confusing for users who may not necessarily be extremely tech savvy. Also, the fact that a logged in user can still create an account seems like a weird thing to do. Not sure if this was done on purpose, but it really seems like it's just going to confuse people when they sign up, and still see a button asking them to sign up. Then when they sign up again, they get an error saying that their email is already in use.
I also noticed that in the User controller tests that we're testing that a logged in user can sign up and create profiles. given that the user will have to log out to manage any additional accounts anyway, this seems like an unnecessary/unwanted feature. I wanted to post here and make sure that wasn't a design decision that I just don't understand before I spend time "fixing" it.
My idea was to have Users#new redirect to Users#edit for logged in users. Let me know if I'm missing something and we want it to stay the way it is.