gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source.
https://gno.land/
Other
880 stars 364 forks source link

RFC: move gnovm/pkg/gnolang/precompile.go out of pkg/gnolang/ #1054

Open piux2 opened 1 year ago

piux2 commented 1 year ago

Description

we might want to move gnovm/pkg/gnolang/precompile.go out of gnovm/pkg/gnolang/

For following reasons:

Proposal:

Open for suggestions and comments.

moul commented 1 year ago

The path gnovm/pkg/tools isn't clear in my opinion.

To make it clearer, I suggest moving it to gnovm/cmd/gno/precompile.go, gnovm/cmd/gno/internal/precompile.go, or gnovm/pkg/precompile.

Also, it's worth noting that we might use it for GnoffeeScript later. Check this: https://github.com/gnolang/hackerspace/issues/22.


My opinion: I think we should move to cmd/gno/internal/precompile.go for now. We can decide where to put it for wider use later.