make install build fails on non-wsl Windows 11 environment

ekleiner commented 1 year ago

`make install` fails on make install fails on non-wsl Windows 11 environment

Description

When trying to run make install on Windows 11 using non-wsl environment (cmd, Git bash) - build it fails with the next error: ..\tm2\pkg\commands\utils.go:44:38: cannot use fd (variable of type syscall.Handle) as int value in argument to term.ReadPassword

Might not need resolution since Non-WSL environment is not recommended (means, not supported?) according to README.md

Your environment

Windows 11 Pro 22621.2134
master branch b40ac9cda5a5482a4bda7fe12675937a86dba69c

Steps to reproduce

Go to gno dir
Run make install

Observe an error:

$ make install
C:/ProgramData/chocolatey/lib/make/tools/install/bin/make.exe --no-print-directory -C ./gno.land        install.gnokey
go install ./cmd/gnokey
# github.com/gnolang/gno/tm2/pkg/commands
..\tm2\pkg\commands\utils.go:44:38: cannot use fd (variable of type syscall.Handle) as int value in argument to term.ReadPassword
make[1]: *** [Makefile:22: install.gnokey] Error 1
make: *** [Makefile:13: install_gnokey] Error 2

ekleiner commented 1 year ago

Seem to be related to issue 34612: x/crypto/ssh/terminal: terminal.ReadPassword doesn't work when using Bash for Windows (from Git installation) describetd at go repo

moul commented 1 year ago

Thank you for your feedback.

We are currently refactoring the client component of tm2 to streamline the process of creating SDKs in Go. Once completed, this will significantly reduce the size of the CLI package, making it simpler to enhance Windows support.

Please note: While Windows support isn't our top priority at this time, we recognize its importance, especially for gnokey. If you or someone you know can enhance Windows support without compromising code clarity, we welcome a PR. In the meantime, we recommend using a Linux-based host (VM/server/OS).

Related with #1047

thehowl commented 1 year ago

Seem to be related to issue ...

Slightly - that might be a problem when using gnokey at runtime; this is a compilation error.

I followed the issue you linked and adapted the code there for the fix; tell me if #1089 fixes the issue for you. Cheers!

gnolang / gno