Critical Issue: configurable VM parameter could halt the chain.

gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source.

https://gno.land/

Other

882 stars 364 forks source link

Critical Issue: configurable VM parameter could halt the chain. #1418

Open piux2 opened 10 months ago

piux2 commented 10 months ago

Description

https://github.com/gnolang/gno/commit/a8675d30e1b2d658d333c24e4a593eefe6969505#r134400942

VM parameter should instead be remain as hard-coded values, as they were originally, or specified as parameters in the genesis file. Using it as a config parameter is not appropriate. It could break consensus and halt the chain.

thehowl commented 10 months ago

2c:

the original GnoChess realm required IIRC ~20M gas for publishing, so in general I think we should change the maxgas per TX/block to be either 50M or 100M.
regarding your concern, the change by Antonio actually only affects genesis as he stated; the reason for that is that the limit to 10M gas persists in the ConsensusParams

moul commented 10 months ago

Here is the original proposal I made regarding this variable: https://github.com/gnolang/gno/pull/828#pullrequestreview-1433955121