search

gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source
https://gno.land/
Other
877 stars 359 forks source link

`sdk/vm` should perform precompiling and basic validation on `MsgAddPkg` #1661

Closed thehowl closed 4 months ago

thehowl commented 7 months ago

Like it is being done client-side, the precompile check should be performed also server-side. This ensures code is correct for anything that we don't catch right now, including #1086.

thehowl commented 6 months ago

@petar-dambovaliev FYI, I made an implementation of this in #1695 which leverages the existing go type checker go/types to perform the checks; so it doesn't need to go through the transpilation step, and can catch far more errors than gofmt can.

petar-dambovaliev commented 6 months ago

@petar-dambovaliev FYI, I made an implementation of this in #1695 which leverages the existing go type checker go/types to perform the checks; so it doesn't need to go through the transpilation step, and can catch far more errors than gofmt can.

Then we don't have to do anything on this issue.