Open gfanton opened 4 weeks ago
Attention: Patch coverage is 48.42105%
with 98 lines
in your changes missing coverage. Please review.
Project coverage is 54.67%. Comparing base (
4f16ad3
) to head (3c91107
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@deelawn Good point. I will merge your PR (#2281) and then rebase this one on it. I will then update this PR so genesis-file
also loads genesis balance, and let it be overridable by txs-file
and/or balances-file
.
Thinking more about this, I believe we should not authorize balance-file
and/or txs-file
along with genesis-file
, as it would make things more complex and is likely not very useful. If we find a use case for this in the future, we can revisit and rework this part.
Waiting on @leohhhn to update the documentation
@gfanton Just a nitpick, not all of us are fluent in Amino binary :)
@zivkovicmilos I will updated this in a future PR. At the moment, it doesn't take into account the type of the event and just logs it with a %v
. Improving gnodev log is definitely on my to-do list :)
This PR adds the ability to manipulate transactions:
P
andN
commands.Ctrl+S
and restore it later withCtrl+R
(reset command).E
command.-genesis-file
flag.~TODO:~
Contributors' checklist...
- [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).