search

gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source
https://gno.land/
Other
842 stars 343 forks source link

fix(gnoclient): Return error when getting keypair information #2300

Closed linhpn99 closed 1 week ago

linhpn99 commented 3 weeks ago

Relate to https://github.com/gnolang/gno/issues/2133

Contributors' checklist... - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 54.68%. Comparing base (eef0039) to head (61a2706).

Files Patch % Lines
gno.land/pkg/gnoclient/client_txs.go 50.00% 5 Missing and 5 partials :warning:
gno.land/pkg/gnoclient/signer.go 28.57% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2300 +/- ## ========================================== - Coverage 54.68% 54.68% -0.01% ========================================== Files 582 582 Lines 78330 78345 +15 ========================================== + Hits 42838 42840 +2 - Misses 32285 32293 +8 - Partials 3207 3212 +5 ``` | [Flag](https://app.codecov.io/gh/gnolang/gno/pull/2300/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | Coverage Δ | | |---|---|---| | [gno.land](https://app.codecov.io/gh/gnolang/gno/pull/2300/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `61.81% <44.44%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

linhpn99 commented 3 weeks ago

This PR is not currently fully covered by unit tests, however I have added the necessary unit tests for signers in this PR https://github.com/gnolang/gno/pull/2209

thehowl commented 1 week ago

@linhpn99 Please don't press the "re-request review" button if you've received approvals