feat: improve p/ownable API - Githubissues

gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source

https://gno.land/

Other

839 stars 342 forks source link

feat: improve p/ownable API #2330

Closed moul closed 1 week ago

moul commented 2 weeks ago

Improve the p/ownable API based on my needs encountered recently.

switch from origcaller to prevrealm
add AssertXXX helper
add a new constructor taking an arbitrary address
improve coding style in tests
identified a new bug with std.TestSetRealm (cc @thehowl)

Part of #2150

linhpn99 commented 2 weeks ago

hey @moul, we still have this pr https://github.com/gnolang/gno/pull/2198 related which is under review

moul commented 2 weeks ago

@linhpn99, I've left several comments. Your implementation is not yet ready.

You'll need to update your pull request based on these new additions.

moul commented 2 weeks ago

Added std.Emit. But I don't know how to test them from unit tests.

leohhhn commented 2 weeks ago

@moul

Made an issue/discussion on testing emitted events: https://github.com/gnolang/gno/issues/2338