Open thinhnx-var opened 2 weeks ago
Attention: Patch coverage is 85.18519%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 54.63%. Comparing base (
e7e47d2
) to head (5e9d999
).
Files | Patch % | Lines |
---|---|---|
tm2/pkg/crypto/keys/client/verify.go | 84.61% | 2 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @thinhnx-var thanks for this - can you please check why the CI is failing and fix it?
@leohhhn yeah sure. Maybe CI failed because CI-Lint. I gonna fix it up.
Contributors' checklist...
- [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).Link to this issue: #2311 This PR changes the
Verify()
to read thesigned doc
, verify the exactly original message hash that was signed. It also addschainid
,account-number
,account-sequence
config flag to thegnokey verify
command.The
sign
function now expose thehex-format of signature
to the IO in oder to feed theverify
as an argument. I think we need better way for user to verify their signed document, which currently need thishex-format
(#2272)What do you think about this change?