Closed zivkovicmilos closed 1 week ago
Attention: Patch coverage is 80.00000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 54.64%. Comparing base (
e7e47d2
) to head (3286abe
).
Files | Patch % | Lines |
---|---|---|
gno.land/cmd/gnoland/secrets_get.go | 80.00% | 2 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you @zivkovicmilos to bring this in. It certainly improves the bootstrap experience.
One small feedback. WOuld it make sense to call the command NodeId
rather than NodeKey
. What is the rationale behind the choice of word NodeKey
?
@r3v4s Thank you for the heads up about the protocol part of the P2P address 🙏
I've resolved it in: dc9a07e
@mazzy89
I've updated it to NodeID
, since we display more information now 👍
Thank you for the suggestion 🙏
Description
Closes #1922
This PR introduces a new section to the
Node P2P Info
secrets output, that displays the P2P connection address. The secrets fetch command remains unchanged, and this info can be displayed by callinggnoland secrets get NodeKey
It displays the following values:
These values will be easily fetch-able when we introduce json output support for these outputs in #2301
cc @mazzy89
Contributors' checklist...
- [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).