search

gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source
https://gno.land/
Other
839 stars 342 forks source link

feat: add support for `--json` output in secrets fetching #2363

Closed zivkovicmilos closed 1 week ago

zivkovicmilos commented 1 week ago

Description

This PR introduces a new --json flag for secrets fetch output, while keeping the old "structured" terminal output.

I propose we start thinking about how to drop the structured output completely, and mimic the display functionality we have for gnoland config get, with key value pairs, so our DevOps friends retain a bit of sanity.

Closes #2301 Closes #2331

sample

cc @mazzy89

Contributors' checklist... - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 86.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.66%. Comparing base (7b8a893) to head (54191cf).

Files Patch % Lines
gno.land/cmd/gnoland/secrets_get.go 86.66% 3 Missing and 7 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2363 +/- ## ========================================== + Coverage 54.63% 54.66% +0.02% ========================================== Files 582 582 Lines 78401 78454 +53 ========================================== + Hits 42832 42883 +51 - Misses 32359 32360 +1 - Partials 3210 3211 +1 ``` | [Flag](https://app.codecov.io/gh/gnolang/gno/pull/2363/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | Coverage Δ | | |---|---|---| | [gno.land](https://app.codecov.io/gh/gnolang/gno/pull/2363/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `62.40% <86.66%> (+0.41%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zivkovicmilos commented 1 week ago

@ajnavarro @gfanton Closing in favor of #2393