search

gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source
https://gno.land/
Other
839 stars 342 forks source link

fix(gnokeykc): gnokeykc maketx {addpkg,call,run} missing because of tm2 separation (fixes #2373) #2375

Open grepsuzette opened 1 week ago

grepsuzette commented 1 week ago

Fixes #2373.

Seems gnokeykc was indirectly broken in #1483 (when tm2 was made completely independent from gno messages as addpkg).

gnokey now makes use of github.com/gnolang/gno/gno.land/pkg/keyscli and this PR proposes to use the same root cmd.

https://github.com/gnolang/gno/blob/5fdbce0e1fe533165c0c2009e93695ece677b2bd/gno.land/pkg/keyscli/README.md?plain=1#L1-L12

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.64%. Comparing base (aa9c64a) to head (e476564).

Files Patch % Lines
contribs/gnokeykc/main.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2375 +/- ## ======================================= Coverage 54.63% 54.64% ======================================= Files 581 581 Lines 77967 77967 ======================================= + Hits 42601 42603 +2 + Misses 32186 32185 -1 + Partials 3180 3179 -1 ``` | [Flag](https://app.codecov.io/gh/gnolang/gno/pull/2375/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | Coverage Δ | | |---|---|---| | [contribs/gnodev](https://app.codecov.io/gh/gnolang/gno/pull/2375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `23.81% <ø> (ø)` | | | [contribs/gnofaucet](https://app.codecov.io/gh/gnolang/gno/pull/2375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `15.31% <ø> (+0.85%)` | :arrow_up: | | [contribs/gnokeykc](https://app.codecov.io/gh/gnolang/gno/pull/2375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `0.00% <0.00%> (ø)` | | | [contribs/gnomd](https://app.codecov.io/gh/gnolang/gno/pull/2375/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `0.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.