Open gfanton opened 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 59.75%. Comparing base (
7b8a893
) to head (5897fdb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't think we actually lost coverage. I believe the reason why the gnovm
flag coverage is decreasing by 20% is because enabling coverage on txtar
also generates coverage for tm2
packages. Therefore, the gnovm
directory itself has not lost coverage. However, by including tm2
packages in the gnovm
flags, we cover 20% less than gnovm packages only.
Coverage with gnovm
flags including txtar
(from gnovm/cmd/gno
):
Coverage with gnovm
flags excluding txtar
(from gnovm/cmd/gno
):
@ajnavarro An idea to avoid having gnovm
flags "corrupted" by txtar
coverage, is to put txtar
coverage under its own flag, such as gnovm/txtar
.
@ajnavarro should be good now
Add back coverage support for
txtar
, which was removed during the CI rework. This only includestxtar
test files fromgnovm
package (not those for gnoland, I will do that in another PR). It adds approximately 5% coverage, which is a non-negligible.Contributors' checklist...
- [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).