gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source
https://gno.land/
Other
841 stars 342 forks source link

feat(keeper)!: use <pkgpath>.<expr> syntax for qeval; <pkgpath>:<path> for qrender #2382

Closed thehowl closed 1 week ago

thehowl commented 1 week ago

This is a switch that was discussed with @leohhhn and @moul. It switches the current syntax for qeval, which requires a newline as a separator, to use a dot . instead (ie. gno.land/r/demo/users.MyFunction(123)). For qrender, this is switched to a colon :, like the gnoweb render: gno.land/r/demo/users:u/morgan.

BREAKING CHANGE: current qeval and qrender calls using the RPC endpoints will have to be changed. No changes are required for gnoclient users.

Contributors' checklist... - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
leohhhn commented 1 week ago

Related: https://github.com/gnolang/gno/issues/2349

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.64%. Comparing base (7b8a893) to head (73772ba). Report is 9 commits behind head on master.

Files Patch % Lines
gno.land/pkg/sdk/vm/handler.go 64.70% 6 Missing :warning:
gno.land/pkg/gnoclient/client_queries.go 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2382 +/- ## ========================================== + Coverage 54.63% 54.64% +0.01% ========================================== Files 582 582 Lines 78401 78402 +1 ========================================== + Hits 42832 42843 +11 + Misses 32359 32349 -10 Partials 3210 3210 ``` | [Flag](https://app.codecov.io/gh/gnolang/gno/pull/2382/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | Coverage Δ | | |---|---|---| | [gno.land](https://app.codecov.io/gh/gnolang/gno/pull/2382/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `62.22% <66.66%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

leohhhn commented 1 week ago

Codecov? :c