gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source
https://gno.land/
Other
841 stars 342 forks source link

feat: overhaul `gnoland secrets` and `gnoland config` to output JSON #2393

Closed zivkovicmilos closed 4 days ago

zivkovicmilos commented 1 week ago

Description

This PR overhauls the gnoland secrets get and gnoland config get commands to:

Thank you @moul for the suggestion on this πŸ™

sample

cc @albttx @sw360cab @r3v4s @mazzy89

Contributors' checklist... - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 71.96262% with 30 lines in your changes missing coverage. Please review.

Project coverage is 54.68%. Comparing base (072aef3) to head (104736e).

Files Patch % Lines
gno.land/cmd/gnoland/secrets_get.go 75.00% 10 Missing and 7 partials :warning:
gno.land/cmd/gnoland/config.go 60.00% 5 Missing and 5 partials :warning:
gno.land/cmd/gnoland/config_get.go 78.57% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2393 +/- ## ========================================== + Coverage 54.66% 54.68% +0.01% ========================================== Files 583 583 Lines 78508 78502 -6 ========================================== + Hits 42913 42925 +12 + Misses 32384 32369 -15 + Partials 3211 3208 -3 ``` | [Flag](https://app.codecov.io/gh/gnolang/gno/pull/2393/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | Coverage Ξ” | | |---|---|---| | [contribs/gnodev](https://app.codecov.io/gh/gnolang/gno/pull/2393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `23.81% <ΓΈ> (ΓΈ)` | | | [contribs/gnofaucet](https://app.codecov.io/gh/gnolang/gno/pull/2393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `15.31% <ΓΈ> (+0.85%)` | :arrow_up: | | [contribs/gnokeykc](https://app.codecov.io/gh/gnolang/gno/pull/2393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `0.00% <ΓΈ> (ΓΈ)` | | | [contribs/gnomd](https://app.codecov.io/gh/gnolang/gno/pull/2393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `0.00% <ΓΈ> (ΓΈ)` | | | [gno.land](https://app.codecov.io/gh/gnolang/gno/pull/2393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `62.54% <71.96%> (+0.41%)` | :arrow_up: | | [tm2](https://app.codecov.io/gh/gnolang/gno/pull/2393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `54.35% <ΓΈ> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

albttx commented 1 week ago

On a single field, please remove the ", in alpine docker container, there is no jq installed by default

zivkovicmilos commented 1 week ago

On a single field, please remove the ", in alpine docker container, there is no jq installed by default

I added support for the -r flag: da30128