search

gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source
https://gno.land/
Other
841 stars 342 forks source link

WIP: handle loop variables #2429

Open jaekwon opened 6 days ago

jaekwon commented 6 days ago

TODO

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 81.52866% with 58 lines in your changes missing coverage. Please review.

Project coverage is 54.78%. Comparing base (31bbcb6) to head (f8a0769).

Files Patch % Lines
gnovm/pkg/gnolang/preprocess.go 85.44% 25 Missing and 14 partials :warning:
gnovm/tests/file.go 45.00% 10 Missing and 1 partial :warning:
gnovm/pkg/gnolang/nodes_string.go 53.84% 6 Missing :warning:
gnovm/pkg/gnolang/nodes.go 81.81% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## init_static #2429 +/- ## =============================================== + Coverage 54.71% 54.78% +0.07% =============================================== Files 583 583 Lines 78622 78839 +217 =============================================== + Hits 43020 43194 +174 - Misses 32382 32414 +32 - Partials 3220 3231 +11 ``` | [Flag](https://app.codecov.io/gh/gnolang/gno/pull/2429/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | Coverage Δ | | |---|---|---| | [contribs/gnodev](https://app.codecov.io/gh/gnolang/gno/pull/2429/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `23.81% <ø> (ø)` | | | [contribs/gnofaucet](https://app.codecov.io/gh/gnolang/gno/pull/2429/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `15.31% <ø> (+0.85%)` | :arrow_up: | | [contribs/gnokeykc](https://app.codecov.io/gh/gnolang/gno/pull/2429/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `0.00% <ø> (ø)` | | | [contribs/gnomd](https://app.codecov.io/gh/gnolang/gno/pull/2429/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `0.00% <ø> (ø)` | | | [gno.land](https://app.codecov.io/gh/gnolang/gno/pull/2429/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `62.02% <ø> (-0.53%)` | :arrow_down: | | [gnovm](https://app.codecov.io/gh/gnolang/gno/pull/2429/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `60.31% <81.52%> (+0.25%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Kouteki commented 3 hours ago

Fixes https://github.com/gnolang/gno/issues/1135