Open grepsuzette opened 5 days ago
Attention: Patch coverage is 27.27273%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 54.67%. Comparing base (
4dc2712
) to head (4092da9
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
gno.land/cmd/gnoland/start.go | 27.27% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note if this PR is accepted there will be a contradiction with https://github.com/gnolang/gno/blob/f74e5f0554d1604c94f9dcad5b126c55f1e52ff1/docs/gno-infrastructure/validators/setting-up-a-new-chain.md?plain=1#L422-L431
^ there is no -lazy here
we can update the doc to use -lazy, but I also fear I'm missing something.
@zivkovicmilos what's your opinion on this?
Seen your response in #2391:
We're actually looking to completely drop those files from the gnoland start command, because they have no place there, since gnoland genesis covers all of their functionality
Makes sense, yes.
(Edited) This PR addresses #2443 and marks the following
gnoland start
options deprecated if changed from default value without -lazy:The docs were also updated.
Original problem
When you use
gnoland start
with the following options:-genesis-txs-file -genesis-balances-file
Even if your gnoland was never launched (height 0), they require -lazy to have any kind of effect.