gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + Gno.land: a blockchain for timeless code and fair open-source
https://gno.land/
Other
841 stars 342 forks source link

chore(gnoland): mark some options as deprecated, update docs #2444

Open grepsuzette opened 5 days ago

grepsuzette commented 5 days ago

(Edited) This PR addresses #2443 and marks the following gnoland start options deprecated if changed from default value without -lazy:

The docs were also updated.

Original problem

When you use gnoland start with the following options:

-genesis-txs-file -genesis-balances-file

Even if your gnoland was never launched (height 0), they require -lazy to have any kind of effect.

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 54.67%. Comparing base (4dc2712) to head (4092da9). Report is 1 commits behind head on master.

Files Patch % Lines
gno.land/cmd/gnoland/start.go 27.27% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2444 +/- ## ========================================== - Coverage 54.68% 54.67% -0.01% ========================================== Files 583 583 Lines 78503 78508 +5 ========================================== - Hits 42930 42925 -5 - Misses 32366 32375 +9 - Partials 3207 3208 +1 ``` | [Flag](https://app.codecov.io/gh/gnolang/gno/pull/2444/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | Coverage Δ | | |---|---|---| | [contribs/gnodev](https://app.codecov.io/gh/gnolang/gno/pull/2444/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `23.81% <ø> (ø)` | | | [contribs/gnofaucet](https://app.codecov.io/gh/gnolang/gno/pull/2444/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `14.46% <ø> (-0.86%)` | :arrow_down: | | [contribs/gnokeykc](https://app.codecov.io/gh/gnolang/gno/pull/2444/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `0.00% <ø> (ø)` | | | [contribs/gnomd](https://app.codecov.io/gh/gnolang/gno/pull/2444/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `0.00% <ø> (ø)` | | | [gno.land](https://app.codecov.io/gh/gnolang/gno/pull/2444/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `62.40% <27.27%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

grepsuzette commented 5 days ago

Note if this PR is accepted there will be a contradiction with https://github.com/gnolang/gno/blob/f74e5f0554d1604c94f9dcad5b126c55f1e52ff1/docs/gno-infrastructure/validators/setting-up-a-new-chain.md?plain=1#L422-L431

^ there is no -lazy here

and https://github.com/gnolang/gno/blob/f74e5f0554d1604c94f9dcad5b126c55f1e52ff1/docs/gno-infrastructure/validators/setting-up-a-new-chain.md?plain=1#L446-L450

we can update the doc to use -lazy, but I also fear I'm missing something.

@zivkovicmilos what's your opinion on this?

grepsuzette commented 5 days ago

Seen your response in #2391:

We're actually looking to completely drop those files from the gnoland start command, because they have no place there, since gnoland genesis covers all of their functionality

Makes sense, yes.