[gnoland] `/tx?hash=` endpoint not usable

gfant commented 3 months ago

Tx Hash not usable in the node RPC

Description

When you make a tx:

The hash for the tx is not hex encoded
The hash can't be used to check it in the node rpc, no matter if it's hex or not.

Your environment

MacOS Sonoma 14.5
latest (built from the commit 3b42391db98f7be35a99f9a060b589f6b69fd3e3)
main

Steps to reproduce

Make a tx with Adena wallet.
Get the resulting hash.
Try to use the endpoint http://127.0.0.1:26657/tx?hash=_ and substitute it with the hash.

Expected behaviour

The output when accessing that path should be the content of this tx.

Actual behaviour

{
  "jsonrpc": "2.0",
  "id": "",
  "error": {
    "code": -32603,
    "message": "Internal error",
    "data": "Could not find tx result for hash #[hash in hex format]"
  }
}

Proposed solution

I'm currently checking how is this done to give an alternative. Will add an alternative once I understand where it appears

leohhhn commented 3 months ago

cc @thehowl @zivkovicmilos

linhpn99 commented 3 months ago

From a comment of Milos : https://github.com/gnolang/gno/pull/2309#discussion_r1636749456

leohhhn commented 3 months ago

From some testing & discussions, the current state is this.

If you pass in the following request body to the root endpoint, ie localhost:26657/, via a POST request:

{
  "id": 1,
  "jsonrpc": "2.0",
  "method": "tx",
  "params": [
    "dX+7ubf0tsbzQ1zPPh+1Op607o/kj6goWzbrnclR8CE="
  ]
}

It will work. However, using the/tx endpoint while providing it the hash, either wrapped in quotes or not, does not work.

On top of this, when you receive a proper response, the transaction data is actually base64 encoded, so it is not readable. Also, when you do decode the data from base64, you're left with an amino representation that is not fully readable.

linhpn99 commented 3 months ago

I found the root cause and fixed it : https://github.com/gnolang/gno/pull/2518

gnolang / gno