gnolang / gno

Gno: An interpreted, stack-based Go virtual machine to build succinct and composable apps + gno.land: a blockchain for timeless code and fair open-source.
https://gno.land/
Other
899 stars 377 forks source link

refactor: remove useless code and fix a test #3159

Closed aeddi closed 5 days ago

aeddi commented 6 days ago
Contributors' checklist... - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests
codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (7188b1c) to head (e5d9431). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tm2/pkg/bft/consensus/state.go 14.28% 4 Missing and 2 partials :warning:
tm2/pkg/bft/types/block.go 60.00% 1 Missing and 1 partial :warning:
tm2/pkg/bft/consensus/replay.go 0.00% 1 Missing :warning:
tm2/pkg/bft/state/execution.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3159 +/- ## ========================================== + Coverage 63.79% 63.80% +0.01% ========================================== Files 549 549 Lines 78833 78824 -9 ========================================== + Hits 50288 50297 +9 + Misses 25153 25138 -15 + Partials 3392 3389 -3 ``` | [Flag](https://app.codecov.io/gh/gnolang/gno/pull/3159/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | Coverage Δ | | |---|---|---| | [contribs/gnodev](https://app.codecov.io/gh/gnolang/gno/pull/3159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `61.16% <ø> (ø)` | | | [contribs/gnofaucet](https://app.codecov.io/gh/gnolang/gno/pull/3159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `15.77% <ø> (+0.94%)` | :arrow_up: | | [gno.land](https://app.codecov.io/gh/gnolang/gno/pull/3159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `73.70% <ø> (ø)` | | | [gnovm](https://app.codecov.io/gh/gnolang/gno/pull/3159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `67.94% <ø> (ø)` | | | [misc/genstd](https://app.codecov.io/gh/gnolang/gno/pull/3159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `79.72% <ø> (ø)` | | | [tm2](https://app.codecov.io/gh/gnolang/gno/pull/3159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang) | `62.44% <41.17%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gnolang#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: