search

gnolang / hackerspace

Tinker, build, explore Gno - without the monorepo!
9 stars 5 forks source link

x: grc721 full refactor #63

Closed leohhhn closed 3 months ago

leohhhn commented 5 months ago

Description

This is a refactor of the GRC721 package. The idea with this is that we want a fully "by-spec" implementation, and then we can build upon it and experiment.

The process of writing is done in Go, and later converted to Gno.

linhpn99 commented 5 months ago

Can you assign me some issues to solve together ?

n0izn0iz commented 5 months ago

wdyt about using []byte as tokenId type? It would be a superset of eth's uint256 while allowing tokens to have more self-describing and expressive keys I guess it would be annoying to bridge gno nfts to ethereum on the other hand

leohhhn commented 4 months ago

Hey @linhpn99 @n0izn0iz,

I've finished the implementation for this and added an example usage realm. If you want, you can take a look and tell me what you think.

leohhhn commented 4 months ago

Will move this code to the monorepo for visibility :)

linhpn99 commented 4 months ago

Will move this code to the monorepo for visibility :)

Hey @linhpn99 @n0izn0iz,

I've finished the implementation for this and added an example usage realm. If you want, you can take a look and tell me what you think.

is it safe that you call panic() when handling the exception ?

leohhhn commented 4 months ago

@linhpn99 @n0izn0iz

Moved it to the monorepo.

Is it safe that you call panic() when handling the exception?

Will reply on the monorepo