gnoling / UnlinkMKV

Merges ordered chapters / segmented MKVs back into a single file.
MIT License
154 stars 8 forks source link

ED merged at slightly wrong point, OP is fine #58

Open hakanaiseishin opened 1 year ago

hakanaiseishin commented 1 year ago

I'm working with THORA's 1080p Utawarerumono release. The merge works fine, but the ED is placed 2~3 seconds too late in the video. There is a 'next episode preview' after the ED, so at the end of the main chapter you see about 2 seconds of the chapter that's supposed to come after the ED, followed by the ED, then the rest of the chapter that is supposed to come after the ED. I am working with the latest revision (and tested with the previous revision as well) on Windows. I can spin up a Linux VM if there is any significant difference, for testing.

gnoling commented 1 year ago

Without having looked at this directly (I will likely soon) and without a trace log, I think this is likely related to issue #56. In that issue I implemented a work-around for that specific issue, but in general it's not a proper fix for when external chapters have their own timeline on top of the main one.

I would be curious whether that work-around --ignoresegmentstart works for you -- you would need the latest version, as this option was only added about a week ago.

Otherwise a trace log would be helpful, you can get that by adding -ll trace to the command line.

hakanaiseishin commented 1 year ago

Here's the log without the --ignoresegmentstart flag, since in testing I didn't notice a difference in the output, same result either way. Log.txt

hakanaiseishin commented 1 year ago

@gnoling Let me know if you need any additional details, or sample files.