gnome-integration-team / firefox-gnome

GNOME 3 theme for Firefox (previously known as Adwaita)
Mozilla Public License 2.0
253 stars 139 forks source link

Release 17.1 #144

Closed garrett closed 11 years ago

garrett commented 12 years ago

I've done the big merge of the new stuff from Firefox 17. There are little bugs here and there. We need to fix these and support the new features.

You can see the merge on the upgrade-to-17 branch: https://github.com/gnome-integration-team/firefox-gnome/compare/upgrade-to-17

Hopefully we can get these minor issues resolved soon and then release 17.1! (:

New features / changes:

  1. Social integration (Facebook, basically for now)
  2. Plugin blocking (for old versions of Flash and other plugins)

Modifications:

  1. The download window
  2. Devtools debugger / console / etc.
  3. Alerts
  4. Video UI

Current issues:

  1. The back button is too large vertically
  2. URL box is messed up.
garrett commented 12 years ago

Social support is issue #143, btw.

seleznev commented 12 years ago

Ahahahahhahah!

garrett commented 12 years ago

@seleznev: You rock! Thanks for fixing various issues already. (:

Also, I did add a few comments in the merge, as I wasn't sure exactly what to do. When those cases arose, I usually just left in code and added comments, assuming that we could fix in the branch.

garrett commented 12 years ago

Oh, the back button being larger is a result of having the Facebook integration turned on. I guess the Facebook buttons force that whole area to be a bit larger, and the button takes up the space.

seleznev commented 12 years ago

a few comments

Yes, you saved many my time)) Thanks)

Facebook

I hate it now %)

garrett commented 12 years ago

We should try to get 17.1 out ASAP.

I'm looking at the list of bugs for this milestone and see:

  1. Support for Facebook integration #143 (Done enough for release?)
  2. Reverting common styles to let GTK2 theme handle them. #115 (What's the status?)
  3. Scrollbars suck in in-page use #114 (Should we punt to after the release?)
seleznev commented 12 years ago

(Done enough for release?)

Yes.

(What's the status?)

It's look very nice with GNOME 3.6! =)

0rAX0 commented 12 years ago

2 Everything is reverted. Things look fine now.

3 Yes, we'll talk about that after the release.

Thanks. :)

garrett commented 12 years ago

Here are the changes from 16.1 to 17.1: https://github.com/gnome-integration-team/firefox-gnome/compare/16.1...master

We should work on a friendly changelog. (;

garrett commented 12 years ago

Major changes:

Additional list of noticeable changes:

Fore a detailed list of all changes, please view: https://github.com/gnome-integration-team/firefox-gnome/compare/16.1...master

garrett commented 12 years ago

Are we good for release?

(I'm about to be AFK for a bit... but can release either late tonight or sometime tomorrow if we're good. Please let me know if there's anything that needs fixing otherwise.)

0rAX0 commented 12 years ago

Looks good to me.

garrett commented 12 years ago

Tagged, uploaded to github, and submitted to Mozilla.

We don't have any errors, but we do have warnings (all related to prefixing, it seems... and I think at least some of these are prefixed in the upstream theme too):

-moz-linear-gradient is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition-property is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition-duration is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition-timing-function is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition-property is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition-duration is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition-timing-function is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition-property is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition-duration is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition-timing-function is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/aboutSocialError.css -moz-transition is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/devtools/debugger.css -moz-transition is no longer prefixed in Gecko 16.

Warning: Several CSS properties have been unprefixed in Firefox 16 and no longer work in their prefixed form.

Warning: For more information, see https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers and https://hacks.mozilla.org/2012/07/aurora-16-is-out/ chrome/browser/devtools/debugger.css

garrett commented 12 years ago

The warnings don't stop the release; and I can fix those in master with a couple Perl one-liners.

garrett commented 12 years ago

essentially, I did something like this:

perl -p -i -e "s/-moz-foo/foo/g" */*.css
seleznev commented 12 years ago

@garrett, great work! =)

garrett commented 11 years ago

17.1 was released, and is on add-ons as of this past week.