Closed garrett closed 11 years ago
For reference, here's a live changelog between 17.1 and what's in master. It will come in handy in the future. https://github.com/gnome-integration-team/firefox-gnome/compare/17.1...master
Okay, I need to port over the changes ASAP. This is the release week of Firefox 18, according to the schedule. (Thankfully it's not out yet, so we might have a day to a few days to port over the changes.)
I've merged the changes from Firefox 17 to 18 (technically beta 7, but nothing seemed to change from beta 4 to beta 7, so I imagine nothing will change from beta 7 to release) into the update-to-18
branch.
See the changes here: https://github.com/gnome-integration-team/firefox-gnome/compare/master...upgrade-to-18
There wasn't even a single conflict, so I think this might be one of the easiest releases yet. (Note: I haven't tested the changes yet, in either Firefox 17 or 18.)
Also, I ported the text from issue #127 on how I upgrade stuff to the wiki: https://github.com/gnome-integration-team/firefox-gnome/wiki/How-to-upgrade-from-the-upstream-Firefox-theme
In addition, I've shared my local vanilla
branch to the repo @ https://github.com/gnome-integration-team/firefox-gnome/tree/vanilla — so anyone can apply patches based on it.
BTW: The built-in inspector has lost its colors when using the 18.1 theme in Firefox 17. So, to support both Firefox 17 and 18, we'll have to do something special.
EDIT: It's probably related to the removal of theme/chrome/browser/devtools/htmlpanel.css
. Hmm. Odd.
support both Firefox 17 and 18
Just drop support Fx 17. :)
We could do that. The issue is that distributions take a few days. I guess so does Mozilla's add-on site...
@garrett, I reverted htmlpanel.css
for Fx17 (but I don't know what it do %)) and fixed background in Responsive design view. Please test it.
htmlpanel.css
is supposed to add syntax color for the build-in inspector in Firefox. It worked in 17.1, but reverting doesn't seem to do anything (as the color is missing in Firefox 17 now). Firefox 18 colors that area differently (with a light colored theme).
You can view the built-in inspector by right clicking on a page element and choosing Inspect Element (Q)
. The area in question is the HTML view, right above the pathbar.
@garrett, I think it fixed in 9f52743.
// I made a mistake in issue's number. :(
Github now supports checkboxes: https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments
It looks useful for us. (:
Github now supports checkboxes
- [x] Awesome!
I just merged the upgrade-to-18
branch into master; getting ready for a release.
So here's a checklist of stuff that needs to be done before we release:
Anything else?
Here are the changes between the 17.1 tag and what's in master. https://github.com/gnome-integration-team/firefox-gnome/compare/17.1...master
Now we just need to summarize it.
I think this is our user-friendly changelog:
For a detailed changelog, view: https://github.com/gnome-integration-team/firefox-gnome/compare/17.1...18.1
Most things are bundled under that "various misc. UI tweaks" point. That above URL won't work until we tag, fwiw.
Doesn't "various" and "miscellaneous" effectively mean the same thing?
Good catch. I was attempting to multitask. (:
(Fixed)
Okay, I've bumped up the version and, as a bonus, made the XPI building script auto-version the XPI, based on the version in the RDF. It also symlinks, so any scripts that already exist (such as the testing one) should still work without modification.
Are we ready for tagging 18.1 and officially releasing?
Are we ready for tagging 18.1 and officially releasing?
Of course.
as a bonus ...
Well, if you touched this topic... May be postfix like branch-date
will be better? And version
for released builds?
For example, I used code in my fork like here:
if [ $BRANCH = "master" ];
then
# Release
VERSION=$(grep "em:version" theme/install.rdf | sed "s/ *<[a-z:/]*>//g")
NAME="firefox-theme-adwaitans-$VERSION.xpi"
else
# "Daily" build
DATE=$(date --utc +"%Y%m%d%H%M")
NAME="firefox-theme-adwaitans-$BRANCH-$DATE.xpi"
fi
(master
== releases
)
Something like that would be nice.
Tagged and released 18.1. It has been submitted to Mozilla's add-ons site and is also available on Launchpad: https://launchpad.net/gnome-integration/firefox-gnome/firefox-gnome-releases/+download/gnome-firefox-18.1.xpi
This is the bug for discussing the release of 18.1. Firefox 18 will be released on January 6 (or thereabouts).
We have a milestone, but it's often useful to discuss things that are needed for merging, releasing, and other related things.
As Firefox 18 is in beta now, I'd like to merge the sometime in the next week so we can start to be prepared early. Most of the time, the theme changes in betas are very close to the final (and often are exactly the same, or may have very minor changes), so merging from beta makes sense, IMO.