gnome-integration-team / firefox-gnome

GNOME 3 theme for Firefox (previously known as Adwaita)
Mozilla Public License 2.0
253 stars 139 forks source link

Moz add-on issues #191

Closed garrett closed 11 years ago

garrett commented 11 years ago

When 22.2 was approved for Mozilla add-ons, the feedback given was the following:

This version has been approved for the public.

There are some major issues your should fix before next update:

1) missing min, max, close icons on Windows AeroGlass, when menubar is disabled (IMPORTANT!)

2) missing folder icons on ftp/local view ( ftp://ftp.mozilla.org/pub/ & file:///C:/Users/ )

3) attack pages are not styled properly (e.g. https://www.mozilla.org/firefox/its-a-trap.html ) -> missing image, missing red background color etc

4) 'About Firefox' window misses content btw. content not visible on Aurora/Nightly builds

I believe most of these are because the reviewer used "Windows 7 with Firefox 23 & 24", which is:

  1. not our target OS (although we support somewhat due to requests)
  2. newer than the released version (the stable build of Firefox is 22), and as our theme closely tracks with upstream, we're often impacted by upstream changes
seleznev commented 11 years ago

1, 2) It's very older problems (#122). Will be fixed anyway. 3) It's not a bug, it's a feature. @0rAX0 know more about it. 4) It's bug, of course.

Use Microsoft Windows for test theme for Linux - it's really great idea.

seleznev commented 11 years ago

Aurora: Aurora

Firefox (dark GTK theme): Firefox

Firefox (Adwaita): Firefox

garrett commented 11 years ago

Yeah, use an unreleased version of a Windows browser to test a theme for Linux targeting a released browser...

0rAX0 commented 11 years ago

Sorry, I'll resume normal activity very soon.

3) What do they mean by "missing"? I removed them. Should I make it look more dangerous? :)

garrett commented 11 years ago

Yeah, I think they (or at least the guy reviewing it) wants it to look more dangerous somehow?

0rAX0 commented 11 years ago

I'm thinking of a new design that follows the new Private browsing style in Web. This issue should be fixed in the process.

web

seleznev commented 11 years ago

folder

0rAX0 commented 11 years ago

Man, I really need to sit down and design those pages. :\

seleznev commented 11 years ago

We have #203 for {3}. Another items is fixed now. => "closed".