download list items are a bit too large vertically

[garrett]

As mentioned at https://addons.mozilla.org/en-US/firefox/addon/adwaita/reviews/490142/ — we should probably remove some padding. I agree.

Here's what it currently looks like:

It should probably look something like this (pixel sizes are not accurate, but I removed about 12px padding in each item and about 6px between the label and info for each item):

[garrett]

It would be nice to not have the line above the selected items too. I'm not entirely sure how to do that without shifting the list, however.

[seleznev]

How should items look like with progress bar? It will be higher anyway.

[stretchion]

I'm not a developer but this style has solved my issue not completely

@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);

toolbarbutton-1 chromeclass-toolbar-additional, #downloads-indicator,

toolbarbutton-1 chromeclass-toolbar-additional {max-width: 37px !important; max-height: 37px !important; }

toolbarbutton-1 #chromeclass-toolbar-additional {max-width: 37px !important; max-height: 37px !important; }

It solve my problem with the button indicator height but still something weird I've to click the button first to fit inside the toolbar size otherwise once the download has finished the button is too large and is higher than the toolbar size.

[stretchion]

Sorry I forgot to mark the button in the previous picture

[seleznev]

@stretchion, usually problems like here is result of working many extensions together. Problem can be not only in our theme. :)

1.

Your userstyle can be better. "toolbarbutton-1" and "chromeclass-toolbar-additional" is CSS classes. You should use them with dot in beginning (for ex: ".toolbarbutton-1").

I.e. your userslyle is equivalent to this:

@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);

#downloads-indicator {
  max-width: 37px !important;
  max-height: 37px !important;
}

And please try add #downloads-button too. For example:

@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");

#downloads-button,
#downloads-indicator {
  width: 100px !important;
  height: 100px !important;
}

2.

We needed some additional information: version of your browser, our theme, list of extensions that affect to appearance (for reproduce the problem). And please post screenshots with:

• enabled this userstyle:

@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");

#downloads-button,
#downloads-indicator {
  outline: 1px solid #f0f;
}

• default theme.

[stretchion]

Thank you for your precious tips and the answer. I tried these tips but unfortunately it's not fixed. If the Download button is in it's default position the last style you posted will fix it for the (height & width) problem but without an icon displayed also without the style it is still big. in addition if the Download button is in the Tab-bar totally nothing working with it . Once the download has finished it become very big and nothing displayed inside of that big button and it make it bigger . All the above data are on a clean user profile with only Stylish extension enabled and the user style mentioned. My Troubleshooting informations are in Paste-bin. It's working perfectly but this button only. Maybe it's all a compatibility issue with the new Firefox Thank you :) http://pastebin.com/TjuukCNz

[seleznev]

Name: Firefox-Trunk Version: 25.0a1

It's very important. But and with Nightly (not UX) our theme should work fine now.

---

My ideas:

1. You use old version of our GNOME theme (simple to check and fix, he-he). Should be v22.2.
2. Your version of Nightly is broken. To check it try another build or Firefox from stable branch (22.0).
3. Some userstyle / extension change icon of the download button. Try check it with clear profile.
4. Try this userstyle:

@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");

@-moz-document url("chrome://browser/content/browser.xul") {

#downloads-button {
  list-style-image: url("chrome://browser/skin/Toolbar-small.png") !important;
  -moz-image-region: rect(0px 16px 16px 0px) !important;
}

#downloads-indicator > #downloads-indicator-anchor > #downloads-indicator-icon {
  background: -moz-image-rect(url("chrome://browser/skin/Toolbar-small.png"),
                              0, 16, 16, 0) center no-repeat !important;
}

}

It should apply default icon. Also please check exist file: chrome://browser/skin/Toolbar-small.png.

UPD: I can reproduce problem only if was remove directory chrome/browser/downloads from sources. It's really strange.

[stretchion]

Thank you very much man it works on Firefox 22. Sorry for being so annoying. ☉‿☉ That theme is just perfect. Thank you again in advance.