gnome-integration-team / firefox-gnome

GNOME 3 theme for Firefox (previously known as Adwaita)
Mozilla Public License 2.0
253 stars 139 forks source link

Redesign the 'its-a-trap' page et al. #203

Closed 0rAX0 closed 10 years ago

0rAX0 commented 11 years ago

This page will track the progress of those about:stuff pages. I'm planning to make them simpler and draw 128x128 icons for the main ones like the one(s) in Web:

deepinscreenshot20130920175948

Please feel free to help. :)

0rAX0 commented 10 years ago

Hey, people!

I know I'm way over-time with this. Sorry, life is happening. :P

Here's what I have so far as a mockup. I plan to make the icon + title with appropriate colors for each page. What do you think? @seleznev @garrett

ff

(the plan was for me to work on a local branch and deliver the work, but if any one wants to help please do :)

garrett commented 10 years ago

What do the colors mean?

It also looks a little weird that the eye is split like that, but it does look fantastic otherwise. (:

0rAX0 commented 10 years ago

The purple is what mozilla chose for private browsing. Red for danger...

I'll try other things...

seleznev commented 10 years ago

the icon + title with appropriate colors for each page

Sounds good to me. :)

any one wants

I want, but how can I help? :(

I tried do it in the ux branch, but it need some tweaks (for ex. right margin doesn't looks correct).

gnome-203

0rAX0 commented 10 years ago

Looks awesome, @seleznev !! Maybe we should give it its own branch?

seleznev commented 10 years ago

Maybe we should give it its own branch?

Would you like to see it in 26.1? If yes, we should have a different branch, of course.

0rAX0 commented 10 years ago

Hmm, not sure if I can finish from my side by 26.1. I just don't want to test/work on the ux brach/firefox that's all

0rAX0 commented 10 years ago

Sorry for the long delay, was offline. :package:

Are we good here, @garrett @seleznev ?

deepinscreenshot20140123151213 deepinscreenshot20140123151158

seleznev commented 10 years ago

I really like it! :+1:

// You know, any variant is nice for me. :no_mouth:

0rAX0 commented 10 years ago

@seleznev Where are those pages you made? I've created a new branch for them please push there. :)

seleznev commented 10 years ago

However it needs polishing. %) Fonts, icon position, maybe margins.

0rAX0 commented 10 years ago

Thanks @seleznev I'll take a look at it :)

seleznev commented 10 years ago

@0rAX0, are you sure that bold font should be removed from this block: screenshot from 2014-01-31 19 52 32 ?

// http://www.mozilla.org/firefox/its-a-trap.html

0rAX0 commented 10 years ago

@seleznev No no, I made a mistake in the mockup. Sorry. :P

0rAX0 commented 10 years ago

@seleznev @garrett Are there any other important pages that need a facelift?

seleznev commented 10 years ago

important pages

I don't know, but may be "This Connection is Untrusted" page should have colored title too?

garrett commented 10 years ago

I see that “This Connection is Untrusted” page several times a day when working… that'd be much appreciated.

(BTW: I'm back to work as of yesterday — finally this eternal Winter sickness loop is possibly ending?! Hopefully I can find some time for non-work computer stuff too. And photography, but that's a little offtopic here.)

0rAX0 commented 10 years ago

cu

Sorry for taking so long @garrett @seleznev , feedback please. :)

seleznev commented 10 years ago

I like it! :-)

0rAX0 commented 10 years ago

:smile:

garrett commented 10 years ago

It's nice, even if not flat like the rest. I guess it certainly stands out?

Should the shield be broken, perhaps? Or feature a question mark?

0rAX0 commented 10 years ago

I guess it certainly stands out?

Yes, it does. :\

Should the shield be broken, perhaps? Or feature a question mark?

Trying them out.

0rAX0 commented 10 years ago

cu

I think this is better @garrett

garrett commented 10 years ago

The other one was really nice looking, but I think this one is clearer (as it matches more with the text). So it works! :smiley:

seleznev commented 10 years ago

@0rAX0, please check it! :)

seleznev commented 10 years ago

@0rAX0, should all buttons on about pages look like the "Try again" button on a "Problem loading page"?

0rAX0 commented 10 years ago

@seleznev

please check it! :)

:+1: Looking good. :)

look like the "Try again" button

Do you have a screenie? I can't see broken addresses. :\

deepinscreenshot20140317232310

seleznev commented 10 years ago

Hm... May be this link can help: about:neterror or file:///not-found.

screenie

screenshot from 2014-03-18 05 35 32

UPD: Sorry, I made "inexact" screenshot. Buttons in an active state:

On netError.xhtml: netError.xhtml

On another pages: all another pages

0rAX0 commented 10 years ago

Hmm, yes, maybe it's better to leave them as buttons. Not that I don't want to customize them :octopus: What do you think @garrett ?

Btw, that page looks like it needs a design. :)

garrett commented 10 years ago

Buttons are fine.

Yeah, "file not found" looks bland.

0rAX0 commented 10 years ago

@seleznev

UPD:

We should get the styling from the current theme, no?

seleznev commented 10 years ago

screenshot from 2014-03-18 23 37 26

0rAX0 commented 10 years ago

:+1: That's cleaner.

0rAX0 commented 10 years ago

cu

Done. Feedback please @garrett @seleznev

seleznev commented 10 years ago

Awesome! :-)


What pages should have this design?

netError.css used for many pages, for ex Offline mode. If we will use code like @-moz-document url-prefix("about:neterror?e=netOffline") {}, we should have list of all affected pages.

List of error codes that I can find:

UPD: Link doesn't work. :( Please copy about:neterror?e=netOffline&u=http://ya.ru to address bar.

0rAX0 commented 10 years ago

Hmm, interesting list. :zap: Not sure whether the 'file' icon can work of all of those. :\

seleznev commented 10 years ago

Not sure whether the 'file' icon can work of all of those. :\

It isn't problem, just select items from this list. %) I like dnsNotFound, netReset, protocolNotFound, remoteXUL. Maybe anything else. :)

UPD: I never saw most pages from this list. :|

garrett commented 10 years ago

Hahaha. I :heart: that FNF graphic. :clap:

0rAX0 commented 10 years ago

@seleznev Let's do it for all of them except phishingBlocked malwareBlocked unsafeContentType and Offline Mode :octopus:

@garrett haha! thanks. :)

0rAX0 commented 10 years ago

@seleznev phishingBlocked malwareBlocked unsafeContentType could use the reported web forgery style. This only leaves us the Offline mode?

seleznev commented 10 years ago

phishingBlocked

This code was deleted. %)

malwareBlocked, unsafeContentType

But this pages doesn't use Reported Web Forgery! style in default theme. :(

malwareBlocked

I think, nothing uses this code. May be we should forget about this page?)

unsafeContentType

I like "file not found" style for it. :)

0rAX0 commented 10 years ago

@seleznev

This code was deleted. %)

:+1:

But this pages doesn't use Reported Web Forgery! style in default theme. :(

Hmm, I'll look it up. Our icon should work though.

I think, nothing uses this code. May be we should forget about this page?) I like "file not found" style for it. :)

Ok, good :+1:

0rAX0 commented 10 years ago

Reported Web Forgery!

This has a stop sign in it and our stop icon should work, I think we're safe to use it there even if it's not used by default.

seleznev commented 10 years ago

@0rAX0, did you talk about malwareBlocked page?


Update for the list [1]:

0rAX0 commented 10 years ago

@seleznev Yes, sorry. :P

seleznev commented 10 years ago

@0rAX0, can I add "netOffline" to epic URL list and merge about-pages branch into master? :)

0rAX0 commented 10 years ago

@seleznev I've duplicated the file-not-found icon, please use it in netOffline and merge, I'll replace it when I make a new icon, okay? :)

seleznev commented 10 years ago

Yep. :)


Last beta (gnome-firefox-29.1b5.xpi) contains this pages now.

0rAX0 commented 10 years ago

Cool, thanks! :)

0rAX0 commented 10 years ago

The (hopefully) final icon and page are now added and fixed. Please review, if there is anything left let's close this. :)

@seleznev @garrett

cu