gnome-integration-team / firefox-gnome

GNOME 3 theme for Firefox (previously known as Adwaita)
Mozilla Public License 2.0
254 stars 139 forks source link

GTK3 support #230

Open Saroufim opened 10 years ago

Saroufim commented 10 years ago

Firefox is on its way to using GTK3. Fedora offers a GTK3 package for Firefox Nightly already. However, gnome-integration plugins look awkward on GTK3 and do not work as well as they do on the current (27.0) version of Firefox.

seleznev commented 10 years ago

Firefox is on its way to using GTK3.

Yes, it's great, and many thanks for developers. But our target is Mozilla's builds (from ftp.mozilla.org) and maybe default packages in linux distributions. The time is not yet. %)

elad661 commented 9 years ago

I'm using Firefox 36 on Fedora 22 right now, which is gtk3 (Fedora 22 and newer uses GTK3 firefox by default). I don't see any visible issues with the theme. I think this issue can be closed.

ghost commented 9 years ago

Second @elad661. Fedora 22 by default use GTK3 Firefox.

garrett commented 9 years ago

I found a few issues with GTK+3 when looking over the theme for a 37.1 release @ issue #323.

I'll quote it here:


Preferences → Advanced

firefox-glitch-advanced

Buttons on a JavaScript prompt

firefox-glitch-buttons2 (I think this might be the focused state of XUL buttons.)


Aside from these two issues, I think it's pretty good.

There's also the headerbar being sectioned off from the window with a stylized line. However, that's the new WM stuff for non-CSD windows and not GTK+3 specifically.

yutzhead commented 9 years ago

Yes, it's great, and many thanks for developers. But our target is Mozilla's builds (from ftp.mozilla.org) and maybe default packages in linux distributions. The time is not yet. %)

People release Alphas and Betas so that projects like this can have their stuff ready ahead of time, and still have time to iron out bugs prior to the release date.

ghost commented 9 years ago

Double this.

2015-04-21 23:33 GMT+03:00 yutzhead notifications@github.com:

Yes, it's great, and many thanks for developers. But our target is Mozilla's builds (from ftp.mozilla.org) and maybe default packages in linux distributions. The time is not yet. %)

People release Alphas and Betas so that projects like this can have their stuff ready ahead of time, and still have time to iron out bugs prior to the release date.

— Reply to this email directly or view it on GitHub https://github.com/gnome-integration-team/firefox-gnome/issues/230#issuecomment-94931350 .

seleznev commented 9 years ago

@yutzhead, @nexfwall,

People release Alphas and Betas so that projects like this can have their stuff ready ahead of time, and still have time to iron out bugs prior to the release date.

Good try, but "Alphas and Betas" is Firefox Beta and Nightly builds. And they still doesn't use GTK3.

I build sources from mozilla-central with enabled gtk3 every month, but I think it isn't ready for release. If Fedora Project use gtk3 as default it is Fedora's peoples problem, not ours. I'm sorry.

More details: https://bugzilla.mozilla.org/show_bug.cgi?id=627699

yutzhead commented 9 years ago

Well, for my particular problem with the transparent background of the statusbar when using Toolbar Autohide, the solution is

diff --git a/theme/shared/browser/browser.css b/theme/shared/browser/browser.css
index 2ea508f..1009ae4 100644
--- a/theme/shared/browser/browser.css
+++ b/theme/shared/browser/browser.css
@@ -47,7 +47,7 @@

 #navigator-toolbox {
   -moz-appearance: none;
-  background-color: transparent;
+  background-color: #ededed;
   border-top: none;
 }

Turns out transparent really means transparent in GTK3.