gnome-integration-team / firefox-gnome

GNOME 3 theme for Firefox (previously known as Adwaita)
Mozilla Public License 2.0
254 stars 139 forks source link

GNOME 3.12 style tab width #248

Open baco opened 10 years ago

baco commented 10 years ago

When enabling 3.12 style en 29.2b3, tabs width are of a fixed size instead of being flexible size to fit tab-bar width with the tabs available.

seleznev commented 10 years ago

Since 29.2 beta 6 version Tweak Extension has tweak for them:

screenshot from 2014-05-04 09 40 57

Latest beta can be installed from this page: https://launchpad.net/gnome-integration/firefox-gnome/firefox-gnome-releases

garrett commented 10 years ago

I've also made a branch that makes tabs act like they do in Web (Epiphany), with the excetion of hiding the tab bar on one tab. I have a commit in the experimental branch that attempts this, but it currently doesn't really work well. I think the tweak extension would have to handle it as I don't think we can do it in pure CSS alone (although I may be wrong).

https://github.com/gnome-integration-team/firefox-gnome/tree/tab-width

https://github.com/gnome-integration-team/firefox-gnome/compare/tab-width

garrett commented 10 years ago

The downside is that this seems to apply immediately instead of after hovering away, so the tabs under the cursor aren't consistent. I wonder if there's a way to fix this behavior.

garrett commented 10 years ago

Modified the changes so that the [+] button expands and using a fixed max-width (crazy-huge) so that the tabs only resize on mouse hover away, yet still fill the their maximum size in a normal state. This should bring us closer to the tab spec.

Also, I have contacted Allan Day about what is most proper when the new tab button [+] must be in the tab row.

garrett commented 10 years ago

FWIW: With what's currently in the tab-width branch, if one moves the new tab to the titlebar and uses the hide tab bar with one tab extension, then Firefox acts like Epiphany.

However, the display between the toolbar and the page content is missing a separator bar now. (Perhaps the line should be included outside of the tab bar?)

Suggestion: At some point, we do a squash merge of the tab-width branch and add functionality in GNOME Tweak to move the new tab to the top and hide the tab bar when no tabs are present, similar to how that linked extension does it. (And fix the tiny visual glitch when this happens by moving where the border is drawn, so that it's always there, even when the tabs aren't.)

ghost commented 9 years ago

However, the display between the toolbar and the page content is missing a separator bar now. (Perhaps the line should be included outside of the tab bar?)

This is issue is there with 33.2b1 and I cannot find previous issue on this to reopen it.

@seleznev, is this unsupported now, or just regression?

seleznev commented 9 years ago

@chpii, I forget about this case. I will try to fix it.

seleznev commented 9 years ago

@chpii, it's fixed in gnome-firefox-33.2b2.xpi. Please try this build and notice if problem still exists.

ghost commented 9 years ago

@seleznev, looks good to me, thank you!

ghost commented 9 years ago

Looks good, but not with dark theme :(

seleznev commented 9 years ago

@chpii,

Looks good, but not with dark theme :(

Fixed. =)

ghost commented 9 years ago

@seleznev Thank you much :star2: