gnome-integration-team / firefox-gnome

GNOME 3 theme for Firefox (previously known as Adwaita)
Mozilla Public License 2.0
254 stars 139 forks source link

Theme does not hide forward button #252

Open baco opened 10 years ago

baco commented 10 years ago

Using GNOME theme tweaks I've checked that the option «Always show forward button» is not checked, but the forward button still shows.

seleznev commented 10 years ago

GNOME theme tweaks

It isn't relevant. Mozilla just put #forward-button inside #urlbar-wrapper and it broken our theme. I missed this point, sorry. :(

mozilla-release (link):

<hbox id="nav-bar-customization-target">
  <toolbaritem id="urlbar-container" class="chromeclass-location" overflows="false">
    <toolbarbutton id="back-button" class="toolbarbutton-1 chromeclass-toolbar-additional"/>
    <toolbarbutton id="forward-button" class="toolbarbutton-1 chromeclass-toolbar-additional"/>
    <dummyobservertarget hidden="true"/>
    <hbox id="urlbar-wrapper">
      <textbox id="urlbar"/>

mozilla-aurora (link):

<hbox id="nav-bar-customization-target">
  <toolbaritem id="urlbar-container" class="chromeclass-location">
    <toolbarbutton id="back-button" class="toolbarbutton-1 chromeclass-toolbar-additional"/>
    <hbox id="urlbar-wrapper">
      <toolbarbutton id="forward-button" class="toolbarbutton-1 chromeclass-toolbar-additional"/>
      <textbox id="urlbar"/>
seleznev commented 10 years ago

Firefox doesn't set "forwarddisabled" attribute to #urlbar-container anymore. And old behavior is impossible without them.

We have 2 choices:

  1. Remove this feature (3448183).
  2. Make a round button like in the default theme.