search

gnome-pomodoro / gnome-pomodoro

A time management utility for GNOME based on the pomodoro technique!
http://gnomepomodoro.org/
GNU General Public License v3.0
2.01k stars 237 forks source link

Long break counter doesn't reset when stopping Pomodoro's #305

Open Vinnl opened 7 years ago

Vinnl commented 7 years ago

It might be due to suspending resuming in between, but I sometimes notice that when I've pressed the [Stop] button at the end of a day, and then click the [Play] button at the start of the next day, that it sometimes starts a long break after three or fewer Pomodoro's. The behaviour I expected was that it would do four Pomodoro's again, as configured, regardless of how many I managed to finish in the previous session (before I pressed [Stop]).

(Note that I did press [Stop], and not [Pause] :)

kamilprusko commented 7 years ago

Confirmed.

I've already made a patch for this 5e78fae0ecc8ac742d3e66c3163aceb4f6b0de99 . Will be in next version, around GNOME 3.26

Vinnl commented 7 years ago

That was fast, sweet!

Why not reset it immediately after disabling, though?

kamilprusko commented 7 years ago

Good suggestion :) I'll give it a try.

I thought it would be more forgiving if one would like to restart pomodoro with the hotkey. Also, a disabled state is very similar to a break - from this point of view it would make sense to reset cycle after ~15 minutes (duration of a long break).

Vinnl commented 7 years ago

Hmm, I don't really understand the hotkey use case - if you want to restart it, don't you want it to be reset? Or do you mean that people would basically want to increase the duration of the current Pomodoro?

kamilprusko commented 7 years ago

When the mind wanders coming from a break, I typically hit the hotkey to start pomodoro over - don't want session cycles to be reset too. This (resetting the state) can be done now from the indicator menu. Overall your suggested behavior should be more intuitive.

Vinnl commented 7 years ago

Ah, I see - a bit like the "Lengthen it" option for breaks, but then for Pomodoro's.

(Note that I'm already perfectly happy with the bugfix, so thank you very much for doing it. I was just trying to see whether I could provide insight in whether I'm using the extension wrong to inform the design, so feel free to ignore :) )