search

gnome-prototypes-team / gnome-music

Gnome Music
https://live.gnome.org/Music
Other
5 stars 13 forks source link

Cache the pixbuf containing the rounded rectangle #139

Closed gquintard closed 11 years ago

gquintard commented 11 years ago

We are using the pixbuf height and width, instead of the final wanted dimensions, preventing from caching more. That's underway.

gquintard commented 11 years ago

And we could internalize the caching of the default icon

gquintard commented 11 years ago

Looking up the key without locking is dangerous, or so I learned. It's better to swap in a new dict (the size will stay small, so it's okay, performance wise) instead of updating it.

I'll change that tonight.

vrutkovs commented 11 years ago 
gnomemusic/albumArtCache.py:268:33: E128 continuation line under-indented for visual indent
gnomemusic/albumArtCache.py:269:33: E128 continuation line under-indented for visual indent
gnomemusic/albumArtCache.py:270:1: W293 blank line contains whitespace
gnomemusic/albumArtCache.py:284:21: E128 continuation line under-indented for visual indent
vrutkovs commented 11 years ago

Works fine, thanks. Please fix formatting - and I'm gonna merge it