gnome-terminator / terminator

multiple GNOME terminals in one window
https://gnome-terminator.org
GNU General Public License v2.0
2.15k stars 259 forks source link

Featrue: how about add light/dark mode theme and sync with system dark mode #775

Open yurenchen000 opened 1 year ago

yurenchen000 commented 1 year ago

like github theme settings:


the gnome theme: light or dark gnome_dark_mode-

yurenchen000 commented 1 year ago

Is it possible implement it in main app? OR maybe I'll try to do it in plugin.

My only concern is that the plugin does not have a settings page, then have to add a right-click menu as the setting entry (if implement in plugin)



Gtk3 Monitor gnome theme change ^1

yurenchen000 commented 1 year ago

BTW: when change profile's Palette Built-in schemes, the current terminals not apply changes (but pick color in Custom scheme, it will apply)

Maybe there need a Apply button ( to apply changes to current opened terminals )?

terminator_theme_setting-

yurenchen000 commented 1 year ago

BTW: how about add other custom palette as schemes, then it's easy to select from list.

so that they can be freely combined into profiles easily

waldyrious commented 1 year ago

Isn't this the same as #72?

yurenchen000 commented 1 year ago

Isn't this the same as #72?

I though it's related,


I think theme has 2 part:


I got some methods to implement it, I'll try it when i free

yurenchen000 commented 1 year ago

About #72 gnome-terminal theme variant

❶ default: app theme follow system theme

dark on dark, light on light theme_1


❷ dark: app dark (but system can be light)

different with system theme theme_2

claudiuxyz commented 1 year ago

It would be nice to be able to set preferred light/dark color scheme so when theme is set to sync with the system to use one of them.

adamryczkowski commented 5 months ago

Is it possible to send some form of a signal to the running terminators to make them change the profile? That would be a good-enough walkaround for me.

yurenchen000 commented 2 months ago

https://github.com/yurenchen000/terminator-autotheme-plugin

@claudiuxyz @adamryczkowski @waldyrious

hi there, good news!
i made it ✨


preview: auto_theme_preview.png

mattrose commented 2 months ago

How easy would it be to incorporate this into terminator itself? If it's not easy, then can I copy your plugin into the included plugins/ directory?

yurenchen000 commented 2 months ago

@mattrose

How easy would it be to incorporate this into terminator itself?

i think it's very easy.

  1. the core code (about theme change detect & profile switch) only about twenty lines (in the just work version 0.9.0) //maybe dark detect is differ on other system, only tested on ubuntu22, gnome 42

  2. all other code is about config save, setting panel, preview, indicator https://github.com/yurenchen000/terminator-autotheme-plugin/releases

  3. maybe the only thing need to think about is the settings UI


If it's not easy, then can I copy your plugin into the included plugins/ directory?

of course yes if you wish