gnosis / MultiSigWallet

Allows multiple parties to agree on transactions before execution.
https://github.com/gnosis/MultiSigWallet/releases
GNU Lesser General Public License v3.0
1.08k stars 768 forks source link

Deploying a wallet via the CLI doesn't deploy #115

Open jamesray1 opened 6 years ago

jamesray1 commented 6 years ago

I ran Parity in one terminal tab, then in another:

$ cd MultiSigWallet
$ truffle migrate 0xf3047b2b495e31c1e39f198448ae5f382739264a,0xd856a6bd2ad4d41101c152c764b8161b9bec5c4f¸0xd856a6bd2ad4d41101c152c764b8161b9bec5c4f 2 10
Using network 'development'.

Running migration: 1_initial_migration.js
  Deploying Migrations...

It froze the computer the first time, and I had to close the terminal to unfreeze it (there was popup window prompting to close the terminal). The second time I ran ionice -c 3 parity and it still outputted this, then I waited but nothing happened. Does Parity need to have finished syncing in order to do this?

jamesray1 commented 6 years ago

I ran parity --light, launched the Parity UI, and got a prompt to sign in the Parity UI app. With a gas price of 1 and 2 it didn't work. Ethgas station had a gas price of 2 as being the fast (<2 min) option.

jamesray1 commented 6 years ago

OK I added my account with funds in it, but now when I run the above command I get a notificaiton prompting me to sign with an account that has 0 ETH, while I want to sign with the account that has ETH.

jamesray1 commented 6 years ago

I used a gas price of 0.3 Gwei (safe low) and got an error:

Using network 'development'.

Running migration: 1_initial_migration.js
  Deploying Migrations...
  ... 0x6f9b093873a2d49ab6e138ebd4a19fa5bb4cf4adaf64a5c49e9ea7bee7b0c33b
Error encountered, bailing. Network state unknown. Review successful transactions manually.
Error: Contract transaction couldn't be found after 50 blocks
    at /home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/contract.js:112:1
    at /home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/filter.js:128:1
    at Array.forEach (<anonymous>)
    at /home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/filter.js:127:1
    at Array.forEach (<anonymous>)
    at Object.onMessage [as callback] (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/filter.js:125:1)
    at /home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:259:1
    at Array.forEach (<anonymous>)
    at /home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:258:10
    at /home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/truffle-migrate/index.js:225:1
    at /home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
    at XMLHttpRequest.request.onreadystatechange (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
    at XMLHttpRequestEventTarget.dispatchEvent (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
    at XMLHttpRequest._setReadyState (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
    at XMLHttpRequest._onHttpResponseEnd (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
    at IncomingMessage.<anonymous> (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
    at IncomingMessage.emit (events.js:185:15)
    at endReadableNT (_stream_readable.js:1106:12)
    at process._tickCallback (internal/process/next_tick.js:178:19)

I suggest that you let it run for longer (say up to half an hour, which corresponds with the safe low).

jamesray1 commented 6 years ago

With a gas price of 1 and 2 it didn't work.

shenopkss commented 6 years ago

I have the same problem. I use Ganache Version 1.1.0-beta.0 (1.1.0-beta.0).

truffle migrate 0x627306090abaB3A6e1400e9345bC60c78a8BEf57 0xf17f52151EbEF6C7334FAD080c5704D77216b732 0xC5fdf4076b8F3A5357c5E395ab970B5B54098Fef 2 --reset

Using network 'development'.

Running migration: 1_initial_migration.js
  Replacing Migrations...
  ... 0x0b482f492f90c57a57ec6de369e04f3532ba460f4f2bc979c2b97f0980d1d103
  Migrations: 0xf25186b5081ff5ce73482ad761db0eb0d25abfbf
Saving successful migration to network...
  ... 0x041851e1787333fc35535ac3a29fd90962dffe4903a0c943ec77bf74e0c08fbb
Saving artifacts...
Running migration: 2_deploy_contracts.js
Wallet with Daily Limit deployed
  Deploying MultiSigWalletWithDailyLimit...
  ... 0xdbedb2d493242e4f91ab6672f7b160f736ee060626051f9f0feeab5fe2663a9c
Error encountered, bailing. Network state unknown. Review successful transactions manually.
Error: The contract code couldn't be stored, please check your gas amount.
    at Object.callback (/Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/contract.js:147:1)
    at /Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/method.js:142:1
    at /Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:89:1
    at /Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/truffle-migrate/index.js:225:1
    at /Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
    at XMLHttpRequest.request.onreadystatechange (/Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
    at XMLHttpRequestEventTarget.dispatchEvent (/Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
    at XMLHttpRequest._setReadyState (/Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
    at XMLHttpRequest._onHttpResponseEnd (/Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
    at IncomingMessage.<anonymous> (/Users/shawn/.nvm/versions/node/v9.3.0/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
kentarohorie commented 5 years ago

I have the same problem

python: 2.7.15 node.js: v8.15.0

node_modules/.bin/truffle migrate 0x861d0e2b17e8fe362308440f2ad6885727a730e0 2
Using network 'development'.

Running migration: 2_deploy_contracts.js
Wallet deployed
  Deploying MultiSigWallet...
  ... 0x1dbb2ddfc8d01831e720720ff429d3a71f1a726bddeba4eeeb8dcce9c6a241aa
Error encountered, bailing. Network state unknown. Review successful transactions manually.
Error: The contract code couldn't be stored, please check your gas amount.
kentarohorie commented 5 years ago

I just mistaked about arguments.

@jamesray1 @shenopkss Perhaps, You also mistake arguments. This is right example about arguments.

node_modules/.bin/truffle migrate 0x861d0e2b17e8fe362308440f2ad6885727a730e0,0x983f715d3bde8252029e7df4343bd4421bb394a6,0x50cc5f1a926adba418eeab9c4a04ee632ec466f6 2

And this error should display when your arguments is wrong

Error: The contract code couldn't be stored, please check your gas amount.

I maked detail of usage.

https://gist.github.com/kentarohorie/5ba326344461889956ef3c69607fed13