search

gnosis / conditional-tokens-contracts

Smart contracts for conditional tokens.
GNU Lesser General Public License v3.0
163 stars 64 forks source link

Report format #53

Closed cag closed 5 years ago

cag commented 5 years ago

Closes #51 Closes #50 (this was done while I was trying to get the original task to work, and the tech debt here made completing the task more difficult, so I just addressed it)

cag commented 5 years ago

Interestingly enough, the gas costs for receiveResult/reportPayouts actually increased here from 102835 to 103039. I wonder if it has to do with my reading multiple times from calldata though.

cag commented 5 years ago

Yeah that was part of it. Down to 102873 now. I suspect the rest of the discrepancy may be due to the previous inline assembly not doing array bounds checking, while the arr[i] notation does.