search

gnosis / conditional-tokens-explorer

9 stars 11 forks source link

[FE] Improve merge UX #358

Closed auryn-macmillan closed 4 years ago

auryn-macmillan commented 4 years ago

When merging a position we should:

Screen record from 2020-09-24 16 41 38

auryn-macmillan commented 4 years ago

automatically populate the condition ID (if a position is built from a combination of conditions, user should be able to select one of the conditions) in the "redeem position" tab.

gabitoesmiapodo commented 4 years ago

@auryn-macmillan

I've been working on this. It seems this workflow needed some re working, and the new search / filter features make this easier for everyone and allows us to get rid of the select position / condition modals (which turned out to be confusing for the users and additionally are on the spaghetti code side of things right now...).

I know this issue is for Merge / Redeem, but it kind of affects everything else, so I changed things for a few extra sections.

Let me know what you think, and if you are OK with these I'll create an epic to modify these sections.

Edit: Updated design with some small tweaks.

30- CTEAF Report Payouts (b) 31- CTEAF Split Position (b) 29- CTEAF Redeem Positions (b) 28- CTEAF Merge Positions (b) 32- CTEAF Filters - Alternative View

gabitoesmiapodo commented 4 years ago

Updated the designs above.

Also available on

https://zpl.io/VQkAzP9 https://zpl.io/VYed9Wn https://zpl.io/beQ874P https://zpl.io/adgm8zL https://zpl.io/bAL6zWx

auryn-macmillan commented 4 years ago

Updated the designs above.

Also available on

https://zpl.io/VQkAzP9 https://zpl.io/VYed9Wn https://zpl.io/beQ874P https://zpl.io/adgm8zL https://zpl.io/bAL6zWx

I can't see the zepelin files, most of it looks good to me. The only thing that jumps out as a concern is the merge tab where it says "Dai" in the amount input box. I guess it should say what you are merging into, which in the example is not Dai because only two of the boxes are selected. Unless I'm misunderstanding what the checkboxes mean. image

gabitoesmiapodo commented 4 years ago

@auryn-macmillan

The only thing that jumps out as a concern is the merge tab where it says "Dai"

Ah, yes, you're right. Probably a leftover from something I copied. I don't think it's even in the app, but I'll check.

So, if everything else is OK, I'll create an epic, issues, etc.

gabitoesmiapodo commented 4 years ago

Moved to a new issue in https://github.com/gnosis/conditional-tokens-explorer/issues/510