gnosis / cowswap

🐮 CowSwap: First Gnosis Protocol v2 UI
https://gnosis.io
GNU General Public License v3.0
113 stars 55 forks source link

[autoconnect] - wallet is not correctly connected and QR code remains #1787

Open MareenG opened 3 years ago

MareenG commented 3 years ago

Description Wallet is not correctly connected when adding a consecutive wallet via wallet connect. The QR code remains visible eventhough the wallet app shows that the wallet was connected. After closing the QR code and trying to connect the wallet again the wallet is connected with the wrong Logo. Related to #1680

How to Reproduce Steps to reproduce the behavior:

  1. Go to cowswap
  2. Click on connect wallet and choose WC
  3. scan QR code, etc..
  4. Disconnect wallet
  5. Repeat with a new wallet (not only another account but also another wallet provider)
  6. OR code is not closed, close it manually
  7. Close modal
  8. try to connect again via WC
  9. Wallet is autoconnected but displays the wrong logo #1788

Expected behavior Connecting a consecutive wallet via WC should be as smooth as adding it for the first time

Screenshots Current issue https://user-images.githubusercontent.com/34510341/140505618-eb5cf1e9-123d-4340-952b-cd677bc3acfd.mov

  1. Connecting with safe
  2. Then disconnecting the Safe
  3. trying to connect a new wallet(Trust) with WC (0:22-0:40) - The trust app showed that I am connected
  4. But QR code remains and cowswap shows that I am not connected
  5. Trying to connect again --- auto connected with the Safe which I disconnected before

As comparison in production:

https://user-images.githubusercontent.com/34510341/140505896-7029e466-8f88-40d7-a9ed-3f615a3a2f49.mov

Additional context See slack conversation https://gnosisinc.slack.com/archives/C025G521XQD/p1636037993009000

anxolin commented 2 years ago

@nenadV91 remember to write in Gnosis Auction chat when this is fixed 👌 They have the same issue