search

gnosis / cowswap

🐮 CowSwap: First Gnosis Protocol v2 UI
https://gnosis.io
GNU General Public License v3.0
113 stars 55 forks source link

[1.5.0] several issues with Argent Wallet #1843

Open MareenG opened 2 years ago

MareenG commented 2 years ago

When testing RC 1.5.0 with the Argent wallet I encountered several issues.

  1. While connecting the issues reported in #1787 and #1788 occured this is not a big issue however it seemed to have a further influence see next point

  2. Wrapping - I couldn't wrap ETH until I disconnected and reconnected the wallet and the correct logo (#1788) was displayed.

  3. Approve token - approved within the Argent app but nothing happened on Cowswap. The waiting for confirmation modal remained open. After closing it I could see on the UI that the token was approved.

  4. Place a sell order - I approved within the Argent app but nothing happened. After several tries it finally worked and the Argent app displayed the swap. However, Cowswap remained stuck in the waiting for approval modal. After a while the Argent app displayed that the transaction went through. Cowswap still remained in the approval modal. After closing the approval modal one could see that the balance was updated but the recent activities did not display the sell order.

    Bildschirmfoto 2021-11-16 um 10 29 26

Screenshot_2021-11-16-10-29-15-533_im argent contractwalletclient

Bildschirmfoto 2021-11-16 um 10 29 41 Bildschirmfoto 2021-11-16 um 10 29 49
  1. Same accounts for buy orders
anxolin commented 2 years ago

I retested the flow with Argent. It sucks a bit the WalletConnect is not super reliable, but I'm not sure what can we do. It looks like is on their end. This doesn't apply to to the #1787 which is a separate issue and we will fix it.

For me, as u can see i managed to APPROVE, UNWRAP, and SELL image

MareenG commented 2 years ago

Yeah, WalletConnect had many hiccups. However, for me the issues was most of the interaction was not displayed in CowSwap only in the Argent App. I can do another couple of tests today and see if and how often thisis still the case.

MareenG commented 2 years ago

I still face the issues that I get notifications in the Argent App but Cowswap doesn't notice if I am signing the transaction or not. Also the swao works but We don't display this in the recent activities In the past I mainly experienced that if WC didn't work properly - there were no notification in the wallet app. This time it is different. Did you try with an IPhone or Andriod device?

MareenG commented 2 years ago

It might be an WC or Argent issue but what puzzles me is that the other wallets work way smoother than this one. It doesn't need to be addressed right away but we still might look into it a bit more. My experience (with an Android device) is that the workflow in cowswap is broken when interacting with Argent.