search

gnosis / cowswap

🐮 CowSwap: First Gnosis Protocol v2 UI
https://gnosis.io
GNU General Public License v3.0
113 stars 55 forks source link

Can't Disconnect Metamask/Coinbase wallet #227

Open MareenG opened 3 years ago

MareenG commented 3 years ago

Not sure if this intended but I can disconnect all wallets except Metamask. If I have selected Metamask I only can change my wallet.

Bildschirmfoto 2021-03-11 um 10 33 01 Bildschirmfoto 2021-03-11 um 10 32 46
alfetopito commented 3 years ago

Spent a while trying to understand why this isn't there. It seems it's a feature not available on Metamask https://github.com/MetaMask/metamask-extension/issues/8990 Neither on walletlink for that matter https://github.com/Uniswap/uniswap-interface/issues/560

So far I haven't found an way to add disconnect for Metamaks in the app UI :/ The only way is to do it on MM itself:

  1. Click on metamask
  2. Click on Connected
  3. Click on the 3 dots
  4. Click on disconnect app

That's not ideal :/

anxolin commented 3 years ago

Thanks Mareen, we briefly talked about this one, but it was not created as an issue, so good call.

The person asking for a "disconnect solution" end up happy with https://github.com/MetaMask/metamask-extension/issues/8990#issuecomment-658985565 setup. If I understand correctly, he "faked" the disconnection as we use to do in old mesa.

As I understand from Metamask, the disconnection is meant more as a I don't trust the app anymore, so they encourage us to do the disconnection as an internal state of the app thing. I don't necessarily agree with their view, but I we could get by with the other approach.

One thing we could do, is open an issue to Uniswap, in case they implement it themselves.

MareenG commented 3 years ago

I just noticed it is the same for the Coinbase wallet. Diconnecting from CowSwap only works via the app

elena-zh commented 3 years ago

Related to #1496

elena-zh commented 2 years ago

The same issue is reproducible when connect to Coinbase wallet