2602 - Fee update on user address change

gnosis / cowswap

🐮 CowSwap: First Gnosis Protocol v2 UI

https://gnosis.io

GNU General Public License v3.0

114 stars 55 forks source link

2602 - Fee update on user address change #2605

Closed W3stside closed 2 years ago

W3stside commented 2 years ago

Fixes #2602 - fee was not being updated on user account changed

Testing

Follow steps in #2602

github-actions[bot] commented 2 years ago

🔭 GP Swap: CoW Protocol v2 Swap UI

elena-zh commented 2 years ago

Frankly, I do not know why, but the fee amount remains to be the same with a discount and without. See the video: https://watch.screencastify.com/v/ii7VO6Z0RY2W3nG9Ip50

W3stside commented 2 years ago

🔭 GP Swap: CoW Protocol v2 Swap UI

Don't think there's any subsidy applied to these environments (PR, barn)

elena-zh commented 2 years ago

Frankly, I do not know why, but the fee amount remains to be the same with a discount and without. See the video: https://watch.screencastify.com/v/ii7VO6Z0RY2W3nG9Ip50

Anyways, I noticed that 'quotes' requests re-run on the account changing event.

W3stside commented 2 years ago

merging, please post merge review if necessary