gnosis / cowswap

🐮 CowSwap: First Gnosis Protocol v2 UI

https://gnosis.io

GNU General Public License v3.0

114 stars 55 forks source link

2604 - Override cow token image in activities modal #2606

Closed W3stside closed 2 years ago

W3stside commented 2 years ago

Summary

Fixes #2604

There currently isn't cow token image on the uni repo: https://raw.githubusercontent.com/Uniswap/assets/master/blockchains/ethereum/assets/0xdef1ca1fb7fbcdc777520aa7f396b4e015f497ab/logo.png

Also check the TODO in the changes but why is the vCow and Cow token logos the same? we have vCowLogo in the assets folder

github-actions[bot] commented 2 years ago

🔭 GP Swap: CoW Protocol v2 Swap UI

elena-zh commented 2 years ago

@W3stside , great! I can see COW token image in the activity modal now. Besides, as you have mentioned above, vCOW and COW tokens have the same image vcow-cow

The only issue I can add here, is that Cow Protocol token's list does not have image in this PR (but has in Prod) cow

W3stside commented 2 years ago

@elena-zh not sure why prod shows it but not local seeing as the list doesn't have a logoURI at all in it. @anxolin any ideas? is there some caching happening in local and the actual list is updated?

W3stside commented 2 years ago

merging, but let's get some eyes on https://github.com/gnosis/cowswap/pull/2606#issuecomment-1081823333 and possible implications of 70028dd

elena-zh commented 2 years ago

@elena-zh not sure why prod shows it but not local seeing as the list doesn't have a logoURI at all in it. @anxolin any ideas? is there some caching happening in local and the actual list is updated?

@W3stside , I realized that the Prod starts showing the icon after I open the list https://tokenlists.org/token-list?url=token-list.cow.eth Before this action, I also see a broken icon there