Closed fairlighteth closed 2 years ago
General comment:
Noticed that many of our routes don't have a fallback from / to no slash. E.g.
/faq/
=> /faq
Right now for instance /claim/
or /profile/
will simply return a 404. Given we have no server redirects in place, should we simply add those extra routes in the App?
General comment: Noticed that many of our routes don't have a fallback from / to no slash. E.g.
/faq/
=>/faq
Right now for instance
/claim/
or/profile/
will simply return a 404. Given we have no server redirects in place, should we simply add those extra routes in the App?
@fairlighteth , we have related issues reported on the board: #1794 and might be #1674
Could you please provide me the PR preview link?
Hey @fairlighteth , great changes! Some my notes:
WIN10+tablet and mobile views (Chrome, FF, Brave): impossible to expand the menu
Seems that the text changes I suggested were not applied:
Can we add a 'minus' icon in order to collapse the menu? However, maybe this was not added intentionally
I think, it would be nice to add an additional margin between these sentences in a mobile view
Thanks!
@elena-zh 1) For now I've disabled to expand logic and instead show the full menu. In future PR's I will iterate on this. 2) Updated 3) Not relevant anymore because of 1) 4) Updated.
@elena-zh Thanks for reviewing. I will keep your comment in mind for a follow up PR!
Summary
Desktop
https://user-images.githubusercontent.com/31534717/160651341-25e75378-936a-4c44-b130-9a6e02f9ee08.mov
Mobile
https://user-images.githubusercontent.com/31534717/160651393-b2532fb9-1057-4158-8a0e-cacb59423a9e.mov
Todos for future PR's
isMobile
hook. Currently when you load the page on Desktop then resize to small, it will not perform the onClick behavior to expand the menu.