gnosis / cowswap

🐮 CowSwap: First Gnosis Protocol v2 UI
https://gnosis.io
GNU General Public License v3.0
114 stars 55 forks source link

Re-style FAQ menu. #2611

Closed fairlighteth closed 2 years ago

fairlighteth commented 2 years ago

Summary

Desktop

https://user-images.githubusercontent.com/31534717/160651341-25e75378-936a-4c44-b130-9a6e02f9ee08.mov

Mobile

https://user-images.githubusercontent.com/31534717/160651393-b2532fb9-1057-4158-8a0e-cacb59423a9e.mov

Todos for future PR's

fairlighteth commented 2 years ago

General comment: Noticed that many of our routes don't have a fallback from / to no slash. E.g. /faq/ => /faq

Right now for instance /claim/ or /profile/ will simply return a 404. Given we have no server redirects in place, should we simply add those extra routes in the App?

elena-zh commented 2 years ago

General comment: Noticed that many of our routes don't have a fallback from / to no slash. E.g. /faq/ => /faq

Right now for instance /claim/ or /profile/ will simply return a 404. Given we have no server redirects in place, should we simply add those extra routes in the App?

@fairlighteth , we have related issues reported on the board: #1794 and might be #1674

elena-zh commented 2 years ago

Could you please provide me the PR preview link?

github-actions[bot] commented 2 years ago
elena-zh commented 2 years ago

Hey @fairlighteth , great changes! Some my notes:

  1. WIN10+tablet and mobile views (Chrome, FF, Brave): impossible to expand the menu not clickable

  2. Seems that the text changes I suggested were not applied: text

  3. Can we add a 'minus' icon in order to collapse the menu? However, maybe this was not added intentionally image

  4. I think, it would be nice to add an additional margin between these sentences in a mobile view add margin

Thanks!

fairlighteth commented 2 years ago

@elena-zh 1) For now I've disabled to expand logic and instead show the full menu. In future PR's I will iterate on this. 2) Updated 3) Not relevant anymore because of 1) 4) Updated.

fairlighteth commented 2 years ago

@elena-zh Thanks for reviewing. I will keep your comment in mind for a follow up PR!