gnosis / cowswap

🐮 CowSwap: First Gnosis Protocol v2 UI
https://gnosis.io
GNU General Public License v3.0
113 stars 55 forks source link

[price] Add Uniswap price #837

Closed anxolin closed 3 years ago

anxolin commented 3 years ago

Description Now we consume prices from APIs, but we could also use our old Uniswap price as one extra price we take into account.

Not sure if this is worth it, because the API already takes uniswap into account. Actually, both of the APIs are a bit smarter and take gas costs into account to decide on the hops.

Proposal Query Uniswap price, and show the best of all the prices.

alfetopito commented 3 years ago

The backend already does that and returns it in the query, if better than Sushiswap. I believe this is not worth it. Unless we want to show a break down of several price sources, like 1inch etc.

anxolin commented 3 years ago

I just thought it's a free of cost price we already have, and adds resilience and maybe a faster price response (when we do eager updates)

But agree is not a prio. I find matcha more important integration

W3stside commented 3 years ago

dup of #1336