search

gnosis / cowswap

🐮 CowSwap: First Gnosis Protocol v2 UI
https://gnosis.io
GNU General Public License v3.0
113 stars 55 forks source link

Improvements - cancelation of orders #860

Closed MareenG closed 3 years ago

MareenG commented 3 years ago

I am adding here a few improvements for the cancelation of orders process:

Recent Activities: I think the green x is a bit missleading. I would suggest to rather go for a grey -

Bildschirmfoto 2021-07-06 um 10 45 27 Bildschirmfoto 2021-07-06 um 10 45 27 Kopie

Same for the pop up modal confirming the cancelation

Bildschirmfoto 2021-07-06 um 10 50 41

I think it might be good to allow the cancelation already in the pop up modal.

Bildschirmfoto 2021-07-06 um 10 49 32
MareenG commented 3 years ago

The explorer doesn't show a difference between a requested cancelation and a successfull cancelation. If possible it would make sense to have cancelation requested instead of Cancled

Bildschirmfoto 2021-07-06 um 11 03 07 Bildschirmfoto 2021-07-06 um 11 04 21
MareenG commented 3 years ago

Maybe incude in the FAQs how we cancel the order and what you are signing if you cancel the order

Bildschirmfoto 2021-07-06 um 12 51 50
MareenG commented 3 years ago

Include a cancelation request pop up:

https://user-images.githubusercontent.com/34510341/124591718-e7aa7e80-de5c-11eb-80df-72465abc5e0a.mov

alfetopito commented 3 years ago

All great suggestions!

Regarding the first one, the account details will be re-worked. Take a look at this proposal by Michel https://www.figma.com/proto/bcoZf5RIgVKDItdOaTZq18/GP-Swap?page-id=1459%3A2&node-id=1468%3A367&viewport=-6038%2C-829%2C0.35277482867240906&scaling=min-zoom

elena-zh commented 3 years ago

Seems that almost all cases are addressed:

  1. side bar is re-worked,
  2. Modals are being reworked in #1483
  3. FAQ contains section about an order cancelling
  4. I have created a separate issue for statuses sync in GP-UI repository https://github.com/gnosis/gp-ui/issues/702

So, I will close the current task