Closed josojo closed 4 years ago
stream lined into one js script
While I agree that there are several inconvenient aspects pointed out here (such as the safe addresses logged differently than used later. cf. #34) I'm not sure it is a good idea to have a single script for this entire process. Or at least, we should keep the possibility to run each of the scripts separately
Deployed new safes for each new deposit wouldn't make sense. Also, at the moment, the safes are deployed in separate transactions and require a sufficiently funded externally owned account (while non-of the other scripts require a special private key).
order placement and transfers are separate transactions for the purpose of security. Although it may be possible to batch together order placement and transfers as a single transaction, we kept them separate so that users could be sure their orders are correct before transferring funds.
I completely agree that the depositList
file format is bad and not very easy to use. Please refer to issue #30. On that note, I would propose that this issue be split up into isolated tasks to that we can all work together to streamline this process, rather than having one large construction site that blocks everyone else.
I'm not sure it is a good idea to have a single script for this entire process. Or at least, we should keep the possibility to run each of the scripts separately
Yes, we will definitively keep it modular, this is important. But offering others a 1-click experience with build-in sanity checks is a must for external customers.
But I also agree that this is not the highest priority, I will focus for now on smoothing the individual steps
Current manual process is as outlined in the following and it should be stream lined into one js script