search

gnosis / dex-services

Off-chain services for the Gnosis Protocol v1.
33 stars 9 forks source link

Make price estimation in prod more high availability #1053

Open e00E opened 4 years ago

e00E commented 4 years ago

https://gnosisinc.slack.com/archives/C6Z2XNL5Q/p1592840939157900?thread_ts=1592832541.145000&cid=C6Z2XNL5Q

We should implement a health and readiness check.

We should make the price estimator not have downtime when the pod is updated in production.

As a readiness check it is enough to check if the price estimator is responding to http requests at all because we only start the http server once the orderbook has updated. This can be a health check or we can check that we actually get a price on a token pair that we expect to always have orders.

fleupold commented 4 years ago

Frontend team noticed some downtimes today https://gnosisinc.slack.com/archives/CPZA1AGKY/p1597075037082000

When aligning the nginx error messages with restart it looked like the majority of rejects happened around a time of restart. Therefore rolling restarts should address this.

fleupold commented 4 years ago

Ready routes are in place. We still need the logic that we only signal it when the second batch starts.

Price-estimator is done.

Volume mounts is still something to figure out with DevOps