search

gnosis / dex-services

Off-chain services for the Gnosis Protocol v1.
33 stars 9 forks source link

Fix PR CI being less strict than master CI #1486

Closed e00E closed 4 years ago

e00E commented 4 years ago

To ensure that Cargo.lock is up to date we build with --locked on CI. However the setup_contracts script which is run only for PRs but not for master didn't have this flag which resulted in a PR being accepted into master where Cargo.lock was not up to date.

https://github.com/gnosis/dex-services/pull/1482 https://github.com/gnosis/dex-services/pull/1485

Test Plan

CI

e00E commented 4 years ago

What I think happened is that first we run setup_contracts.sh which builds without --locked , so this updated the Cargo.lock file in the PR which made the following locked workspace build succeed. On master we only run the locked build without without setup_contracts so there Cargo.lock doesn't get updated and the locked build fails.

fleupold commented 4 years ago

That makes perfect sense - great 🕵️‍♂️ work!