search

gnosis / dex-services

Off-chain services for the Gnosis Protocol v1.
33 stars 9 forks source link

Make the retry api agnostic of how transactions are sent #1548

Closed e00E closed 4 years ago

e00E commented 4 years ago

which is is a big step towards making this a standalone crate. We accomplish this by using traits to encapsulate how the "solution" and the cancellation is sent. This way there is no dependency on StablexContract or even web3. solution_submission has intentionally not yet been fully updated to the new api to keep the PR smaller.

Test Plan

Tests for retry pass but tests for solution_submission have been commented out and code contains a todo! so CI won't pass.

e00E commented 4 years ago

Additional things that I think this module could take care of if it was more tightly coupled are

These can potentially be done by having an optional web3 and ethcontract feature which then exposes extra methods with simpler signatures.