search

gnosis / dex-services

Off-chain services for the Gnosis Protocol v1.
33 stars 9 forks source link

Implement custom benign errors #1617

Closed nlordell closed 3 years ago

nlordell commented 3 years ago

This PR offers a simple work around to help silence benign errors on a per-configuration basis.

Test Plan

Added unit test.

nlordell commented 3 years ago

I think that in our kibana alerts filter we could also filter per pod name to accomplish a similar thing but having this here probably more ergonomic.

I already installed a kibana filter, the issue is that it counts towards the Grafana metrics as a failed batch.

nlordell commented 3 years ago

I would have said this is actually intended (since we are not finding a solution for those batches),

The thing is we want to suppress the alerts for Rinkeby for multiplication overflows. Maybe for v2 we can have a separate category for this kind of failure?